New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when tabindex="0" #19

Closed

aaa2000 opened this issue Aug 3, 2011 · 1 comment

aaa2000 commented Aug 3, 2011

There is a bug when I set tabindex="0" on select menu. The div created set tabindex="".
(Widgets with tabindex=0 will be added to the tab sequence based on document order, see http://www.w3.org/TR/wai-aria-practices/#kbd_general_between )

So, I modify the line

// Check if we have a tabindex set or not
tabindex = $select.attr('tabindex') ? $select.attr('tabindex') : '',

by

// Check if we have a tabindex set or not
tabindex = isNaN($select.attr('tabindex')) ? '' : $select.attr('tabindex'),

CumpsD commented Sep 28, 2012

You can also use this:

tabindex = $select.attr('tabindex') !== undefined ? $select.attr('tabindex') : '',

Robdel12 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment