Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema generator PR doesn't stay up to date with master #32

Open
robere2 opened this issue Nov 4, 2023 · 0 comments
Open

Schema generator PR doesn't stay up to date with master #32

robere2 opened this issue Nov 4, 2023 · 0 comments
Labels
Module: Schemas Issues pertaining to the @mcsb/schemas package. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Type: Bug Issues that are about something which isn't working as expected.

Comments

@robere2
Copy link
Owner

robere2 commented Nov 4, 2023

The schema generator's base branch does not automatically stay up to date with master. This is so we can stack multiple generator outputs into one PR (i.e. if the generator PR isn't merged for a week, if we want all of the generations to be included in the PR, we need to base each generation on the previous one). On the flip side, this means if master gets ahead, we need to somehow get our PR up to date.

I think if the action should check if we can gracefully rebase schemas/patch onto master, and do it if so. If not, reset schemas/patch back to master, thereby discarding changes, before running the generator again.

For now, we can manually rebase the branch, or close the PR and delete the branch to discard changes.

@robere2 robere2 added Type: Bug Issues that are about something which isn't working as expected. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Module: Schemas Issues pertaining to the @mcsb/schemas package. labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Schemas Issues pertaining to the @mcsb/schemas package. Priority: Low Issues which aren't critical, security-related, or significantly beneficial to users. Type: Bug Issues that are about something which isn't working as expected.
Projects
None yet
Development

No branches or pull requests

1 participant