Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer functional on TB 115.3.0 (64-bit) on Windows #10

Open
LispEngineer opened this issue Sep 28, 2023 · 7 comments
Open

No longer functional on TB 115.3.0 (64-bit) on Windows #10

LispEngineer opened this issue Sep 28, 2023 · 7 comments

Comments

@LispEngineer
Copy link

Hi there,

This wonderful extension is no longer functioning for me on TB 115.3.0 (64-bit) on Windows.

  • When I'm in the Inbox view, with one (or several) messages selected, and hit a move mail hotkey, nothing happens. (I don't use the viewer pane.)
  • When I'm in a specific window showing a specific message, the hotkey will work and the message will be moved.

I looked into the code, and it appears that this part results in an array of zero messages:

	const tabs = await browser.tabs.query({
		active: true,
		currentWindow: true,
	});
	let tabId = tabs[0].id;
	const messages = await browser.messageDisplay.getDisplayedMessages(tabId);
	if (!messages) {
		console.log("No messages selected");
		return;
	}

It doesn't fail the !messages check as it seems to be a zero-length array.

I do not know if something has changed or my Thunderbird installation is broken.

Let me know if I can help fix this somehow.

Thanks!

@robert7k
Copy link
Owner

robert7k commented Oct 4, 2023

I cannot reproduce this issue on 115.3.0

Which shortcuts exactly can you reproduce this problem with? Have you tried assigning other shortcuts?

Are you 100% certain the shortcuts used are not already taken by Thunderbird features?

@LispEngineer
Copy link
Author

Hi again. Thanks for the prompt response. A few things:

  • The shortcuts were all Control-Alt-Letter combinations including PNLSK - and work fine on other versions of Thunderbird/Move Mail Shortcuts on my other (Windows 10) computers. This computer is Windows 11, my first Win11 computer.
  • I did a forced downgrade to 102 and things started working again after I reconfigured everything.

The debugger was definitely showing no messages in that section of the code with one or more messages selected in the unified inbox view (with no preview pane), and was being properly invoked by the assigned shortcut key.

The shortcuts worked fine when opening a message in a separate window/tab (e.g., by double clicking a message in the messages list).

STR:

  • View: Classic, Folder Pane - nothing else
  • Show unified inbox
  • Select one or more messages
  • Hit assigned hotkey
  • View log in console which does NOT show No messages selected but later also shows NO message IDs when it would normally print the message IDs

Thanks!

@robert7k
Copy link
Owner

robert7k commented Oct 9, 2023

Can you reproduce the issue with a fresh Thunderbird profile?

Do you have any other plugins installed which could interfere?

@vizustom
Copy link

vizustom commented Oct 10, 2023

I can reproduce this issue on TB 115.3.1 and 115.3.2 64bit Windows. In dev console I see:

Received command move_mail_0.
Got saved folder value: {"folderPath":"/Done","accountId":"account2"}
Message IDs:

No ID.
I have no any other plugin installed.

@LispEngineer
Copy link
Author

I had the same exact symptoms as @vizustom did. I also had no other plugins installed. I will try to do a fresh install of Thunderbird this weekend on a new Win 11 Pro user account and see what happens, and report back.

@ralphslate7825
Copy link

I am having the same issue, and the same JS console:

Received command move_mail_0. 
Got saved folder value: {"folderPath":"/!Recent Archives/Saved Filing","accountId":"account1"}
Message IDs:

@steanne
Copy link

steanne commented Feb 5, 2024

lispengineer said

The shortcuts worked fine when opening a message in a separate window/tab (e.g., by double clicking a message in the messages list).

i will also note that the shortcut works for me if i have the message showing in a preview pane (which i don't always have toggled on.) it's only in the message list without the preview pane open that it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants