Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve stock configuration file, add full option coverage #1

Open
kfiresmith opened this issue Jul 3, 2021 · 1 comment
Open

Comments

@kfiresmith
Copy link

kfiresmith commented Jul 3, 2021

I believe that the stock configuration file at /usr/share/logwatch/default.conf should be preserved in it's original as-packaged format, and that /etc/logwatch/logwatch.conf should instead be created and managed by the role.

Additionally, there is not a lot of configurability to LogWatch, but there are a few settings which don't have coverage within this role. I believe that if we are going to template a configuration file wholesale, we need to provide full configuration coverage within the template.

Both of these changes should be fairly simple and I've added submitting a PR to my backlog, but such a PR would probably be at least a month off - so this issue is mostly to achieve 2 things:

  • Provide a note to self that I need to provide this PR
  • Give enough advance notice of this proposal for any objections to be raised prior to my spending time on this PR

Thanks!

@robertdebock
Copy link
Owner

Hi,

That sounds completely acceptable, I'm open to merge PR's.

Thanks @kfiresmith for reaching out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants