Migrate to Observable and MutableObservable #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I needed some incubation time to adjust to this, but I do see the advantage now.. I'll take this up in the next release later today. Thank you for your effort! 👌 |
|
No problem, thanks for taking a look at this 👍 |
# Conflicts: # Observable/Classes/Observable.swift
|
That was fast @4brunu 😂 |
# Conflicts: # Example/Observable/Views/CollectionView.swift
|
I subscribed to the other PR 😄 |
|
Thanks for merging this 👍 |
|
I believe @Edudjr is working on a PR for this.. |
|
I think so, I was just saying that maybe it's worth waiting to that PR before the next release. |
|
Yes, good idea, let's wait for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #24, this PR tries to fix the issue.
@roberthein What do you think about this? I would like to know your opinion on this.
Thanks