Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for self-sizing cells #15

Closed
HarshilShah opened this issue May 10, 2017 · 3 comments
Closed

Support for self-sizing cells #15

HarshilShah opened this issue May 10, 2017 · 3 comments

Comments

@HarshilShah
Copy link

Hi there, good job on this project, it looks really cool and I am looking forward to using it.

I tried to use it with my collection view in which I’m using self-sizing cells, simply droppping in BouncyLayout() in place of the existing UICollectionViewFlowLayout(), and setting a random .estimatedItemSize before assigning it to the collection view. The self-sizing behaviour doesn’t remain, however, and the cells all get resized to a fixed size.

My project is currently in a haphazard state so I can’t upload the code; however I’m using IGListKit and was able to reproduce this effect with their provided self-sizing cells example.

Do you plan on adding support for self-sizing cells to BouncyLayout? The Instagram people themselves had a bunch of issues with implementing it, so I would understand if you don’t plan on doing so; their codebase would be a great help if you did, however.

Thanks!

@ergonotics
Copy link

ergonotics commented May 10, 2017

Hi, good job on this

Likewise, I am having issues with self sizing cells with BouncyLayout, specifically with rotation where several cells are not displayed after a rotation - scrolling up and down eventually ends up displaying the aforementioned cells. Replacing BouncyLayout by a regular CollectionViewFlowLayout works fine.

specifically, the issue is with the implementation of layoutAttributesForElements(in rect: CGRect) -> [UICollectionViewLayoutAttributes]?

@nhatquangz
Copy link

Hi, Anyone have solution for this issue?

@roberthein
Copy link
Owner

This should be fixed in 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants