Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 warning issued after require('metrohash') #1

Closed
JulianTonti opened this issue Nov 1, 2016 · 6 comments
Closed

v8 warning issued after require('metrohash') #1

JulianTonti opened this issue Nov 1, 2016 · 6 comments

Comments

@JulianTonti
Copy link

After require('metrohash'), node dumps about 10 pages worth of warnings which seem to be the same thing over and over. At the core of it is a V8 warning as follows (note that metrohash functions fine nonetheless, for the time being):

==== C stack trace ===============================

1: v8::Template::Set(v8::Localv8::Name, v8::Localv8::Data, v8::PropertyAttribute)
2: NodeMetroHash<MetroHash64, 8>::Init(char const*, v8::Localv8::Object)
3: InitAll(v8::Localv8::Object)
4: node::DLOpen(v8::FunctionCallbackInfov8::Value const&)
5: v8::internal::FunctionCallbackArguments::Call(void ()(v8::FunctionCallbackInfov8::Value const&))
6: v8::internal::MaybeHandlev8::internal::Object v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate
, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
8: 0xb96d0e092a7
9: 0xb96d0fc16c4
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

@robertklep
Copy link
Owner

Thanks :) Which version of Node is this?

@JulianTonti
Copy link
Author

My bad, I should have stated that: 6.9.1
Running on OS X 10.12

@robertklep
Copy link
Owner

I have to admit that I haven't looked at this module for a while, hence the warnings. I'll take a look!

@robertklep
Copy link
Owner

@JulianTonti just published 1.5.0, try that.

I couldn't even get it to build on v6 and v7 due to outdated dependencies, but after updating those it works again.

@JulianTonti
Copy link
Author

Rebuilt for 6.9.1 and it's It's fixed.
Updated to node 7.0.0, rebuilt again, still good.

Tight work mate!

@robertklep
Copy link
Owner

Thanks for testing! Closing issue 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants