Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in tabs #101

Closed
robertohuertasm opened this issue Jul 22, 2016 · 21 comments
Closed

Icons in tabs #101

robertohuertasm opened this issue Jul 22, 2016 · 21 comments
Assignees
Milestone

Comments

@robertohuertasm
Copy link
Member

No description provided.

@jens1o
Copy link
Member

jens1o commented Jul 22, 2016

👎
I don't like this idea, and even tabs in VSCode is something I don't like generally. Is there an option to disable this also in planning?

@robertohuertasm
Copy link
Member Author

I've been asked by several colleagues to implement this and I like it. I will try to make it optional if feasible to make you happy 😉

@Empereol
Copy link
Contributor

@jens1o Add "workbench.editor.showTabs": false to your User Settings to disable tabs.

@jens1o
Copy link
Member

jens1o commented Jul 26, 2016

No, I actually like tabs(I used them for serveral days, now it is ok in my workflow). But I won't like it, when there is an icon next to the filename in tab view. I want an option for this.

@mysticman
Copy link

mysticman commented Jul 26, 2016

I like this idea, and I think it would be also very usefull like the this extension.

I am waiting for this update :)

@robertohuertasm
Copy link
Member Author

@mysticman could you elaborate your second statement. I'm not sure to understand what you mean... Thanks! 😉

@mysticman
Copy link

Doesn't matter, I just mentioned that this vs-code-icons plugin is a must have plugin for vscode. I cannot live without it, and as I see 44K downloads is also prove this. 👍

@robertohuertasm
Copy link
Member Author

robertohuertasm commented Jul 26, 2016

I completely agree. For what I know they're already working on it. The idea behind this extension was precisely to proof the importance of this cosmetic extension to be vscode native.

@mysticman
Copy link

Here is a quick sample how is it look like the tab with the icons. Please review it. For me is OK, I like it.

tab-icon-sample

@robertohuertasm
Copy link
Member Author

@mysticman don't worry. This issue is next in release cycle. 😉

@jens1o
Copy link
Member

jens1o commented Jul 27, 2016

@mysticman Could you post your editor settings? I like the Atom Style, could you provide it for me too?

@robertohuertasm
Copy link
Member Author

@jens1o I also use it. It's a theme exentension called one https://marketplace.visualstudio.com/items?itemName=andischerer.theme-atom-one-dark

@jens1o
Copy link
Member

jens1o commented Jul 27, 2016

Thank you. I'll take a look.

@robertohuertasm
Copy link
Member Author

Already released in 1.6.0

@devdupont
Copy link

After installing 1.6.0, enabling or updating icons causes tabs to not show at the top of the editor. The blank space for tabs is still allotted, however. Disabling icons causes tabs to appear again.
1

@robertohuertasm
Copy link
Member Author

Any message in your console?

@devdupont
Copy link

Nothing in the debug console

@robertohuertasm
Copy link
Member Author

That's weird. Can you inspect the tab with the element inspector and let me know what you see with a screenwriter?

@devdupont
Copy link

devdupont commented Aug 7, 2016

Oh. Was running on the only computer which hadn't updated to 1.4.0. Must be a new feature. Works now

@robertohuertasm
Copy link
Member Author

Screenshot... Sorry, I'm in mobile phone

@robertohuertasm
Copy link
Member Author

Oh yes, you need 1.4.0 for this to work. I will update the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants