-
-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file extensions not working #146
Comments
Can confirm it. VSCode 1.4 Stable. (Disable and Re-Enable it does not help.) |
My bad... First of all, no regular expression or glob patterns are supported. Second, I didn't really think about file associations already having its own convention (they use "javascript" instead of "js" for associations) so this won't work. I will fix it asap and let you know 😞 The only way for this to work at the moment would be this: "*.es": "js" But as I said, wait for the fix. 😉 |
I've just published 1.5.6 that will fix this. Still not supporting complex patterns but will cover the most common scenarios. To use it, you won't be using file.associations anymore but a custom property inside vsicons: {
"vsicons": {
"useFileAssociations": true,
"associations":{
"*.cc": "css"
}
}
} In your case, first case is not supported at the moment, but I will try to implement it if possible 😉 |
@robertohuertasm updated but does not seem to be working for me. in user settings.json
the options does not appear on the workspace settings (not sure if relevant) same environment as above |
You're right, now only supported extensions will work... . es is not in the list of supported extensions so it won't be considered. I'll try to fix it tonight. Sorry for the inconveniences! |
It's already fixed. #152 |
@robertohuertasm great work, thanks! |
Already released in 1.6.0 |
@robertohuertasm does not work for me. Same config as above (also tried several extensions values |
Please, read the new readme as this has changed to support regular expressions. |
@robertohuertasm Tried a bunch of configs until I hit the update command 😅 |
@rickmed thanks for your feedback. I'll update the readme to make it more explicit. |
vscode 1.4
win 10 x64
I have this
Actual behaviour:
only .js files are "iconized"
The text was updated successfully, but these errors were encountered: