Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entries datastruct #236

Closed
krisdiano opened this issue Sep 18, 2019 · 2 comments
Closed

entries datastruct #236

krisdiano opened this issue Sep 18, 2019 · 2 comments

Comments

@krisdiano
Copy link

now, the datadtruct is slice, in run function, always sort, why not use heap or wheel,

@krisdiano
Copy link
Author

hi, author, i implement cron with heap, and commit a PR, but not pass TestJob function, but it is not a bug, beacues the heap is dynamically adjusted, so failed to TestJob.

@robfig
Copy link
Owner

robfig commented Jan 4, 2020

I don't believe that the extra complexity is necessary. It's hard to imagine a system with so many scheduled tasks that sorting them takes a measurable amount of time. Tasks can not be activated more often than once a second at the most, so I don't see any reason to optimize this case. Thanks for your interest

@robfig robfig closed this as completed Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants