Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event action name for "Baseline" #34

Closed
sekimura opened this issue Jul 8, 2014 · 5 comments
Closed

Event action name for "Baseline" #34

sekimura opened this issue Jul 8, 2014 · 5 comments

Comments

@sekimura
Copy link
Contributor

sekimura commented Jul 8, 2014

Does it make sense to change "Event Action" name from "Percentage" to "Elements" if options.percentage is false and options.elements has some data?

// Establish baseline (0% scroll)                                          
if (options.percentage) {                                                  
  sendEvent('Percentage', 'Baseline');                                     
} else if (options.elements) {                                             
  sendEvent('Elements', 'Baseline');                                       
}      
@robflaherty
Copy link
Owner

That's interesting. I've always thought of the Baseline event as specifically percentage-based, i.e. scrolled = 0%.

So the idea is that it's a little awkward to have the baseline event in a different category if you're only tracking elements?

@sekimura
Copy link
Contributor Author

sekimura commented Jul 8, 2014

I am using elements option and wondering how to get "views with no scroll" segment on google analytics. Using "Percentage" event action name feels a bit odd since I disabled percentage option.

@robflaherty
Copy link
Owner

I think that makes sense. I can include this in the next update or feel free to submit a pull request against the v05-dev branch :)

@sekimura
Copy link
Contributor Author

sekimura commented Jul 9, 2014

Cool. Thank you!

@robflaherty
Copy link
Owner

Merged into dev branch. Will merge into master with next release in the next week or so. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants