Skip to content

Commit

Permalink
HTML Validation fixes
Browse files Browse the repository at this point in the history
It turns out that <script … charset="utf-8">inline script</script> is
not valid (charset is valid with script src). This avoids debug_toolbar
causing HTML validation errors simply by being active.

Signed-off-by: Rob Hudson <rob@cogit8.org>
  • Loading branch information
acdha authored and robhudson committed Oct 20, 2010
1 parent 081198a commit d83df71
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion debug_toolbar/templates/debug_toolbar/base.html
@@ -1,5 +1,5 @@
{% load i18n %}
<script type="text/javascript" charset="utf-8">
<script type="text/javascript">
// <![CDATA[
var DEBUG_TOOLBAR_MEDIA_URL = "{{ DEBUG_TOOLBAR_MEDIA_URL }}";
// ]]>
Expand Down
2 changes: 1 addition & 1 deletion example/templates/jquery/index.html
Expand Up @@ -7,7 +7,7 @@
#v {font-weight:bold;}
</style>
<script type="text/javascript" charset="utf-8" src="{{ MEDIA_URL }}/js/jquery.js"></script>
<script type="text/javascript" charset="utf-8">
<script type="text/javascript">
$(document).ready(function() {
$('p.hide').show();
$('#v').append($.fn.jquery);
Expand Down
2 changes: 1 addition & 1 deletion example/templates/mootools/index.html
Expand Up @@ -6,7 +6,7 @@
.hide {display:none;}
</style>
<script type="text/javascript" charset="utf-8" src="{{ MEDIA_URL }}/js/mootools.js"></script>
<script type="text/javascript" charset="utf-8">
<script type="text/javascript">
window.addEvent('domready', function() {
$$('p.hide').setStyle('display', 'block');
});
Expand Down
2 changes: 1 addition & 1 deletion example/templates/prototype/index.html
Expand Up @@ -6,7 +6,7 @@
.hide {display:none;}
</style>
<script type="text/javascript" charset="utf-8" src="{{ MEDIA_URL }}/js/prototype.js"></script>
<script type="text/javascript" charset="utf-8">
<script type="text/javascript">
document.observe('dom:loaded', function() {
$('showme').removeClassName('hide');
});
Expand Down

0 comments on commit d83df71

Please sign in to comment.