Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appendToBody=true leaves span in body when popper is destroyed #14

Closed
psalaets opened this issue Oct 1, 2017 · 0 comments · Fixed by #15
Closed

appendToBody=true leaves span in body when popper is destroyed #14

psalaets opened this issue Oct 1, 2017 · 0 comments · Fixed by #15

Comments

@psalaets
Copy link
Contributor

psalaets commented Oct 1, 2017

When the appendToBody prop is true, the popper parent element is being left in body.

Reproduces issue: https://jsfiddle.net/psalaets/g7yg9v7s/1/

In that fiddle, the count should never be > 1 but it increases each time you toggle the popover component because the span is not cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant