Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Autocompletion on Styleable Attributes #75

Closed
naturalwarren opened this issue Dec 18, 2017 · 1 comment
Closed

No Autocompletion on Styleable Attributes #75

naturalwarren opened this issue Dec 18, 2017 · 1 comment

Comments

@naturalwarren
Copy link
Contributor

I was using Ticker and noticed that I'm not getting autocomplete in Android Studio 3.0.1 on styleable attributes. I dug in a little bit and discovered that because <declare-styleable name="ticker_TickerView"> isn't named the same as its custom view class Studio can't autocomplete. There's a standard lint shipped for this:

https://android.googlesource.com/platform/tools/base/+/master/lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/CustomViewDetector.java

#73 introduces a backwards incompatible change in preparation for a major release. Would you be open to a PR that renames the XML tag for v2.0.0? This change should be compile time safe and prompt folks to update their XML/source.

@jinatonic
Copy link
Contributor

Ah, good catch, I've noticed that before but never spent the time to figure out why the autocompletion isn't working lol.. feel free to open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants