Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

test: add e2e test case for sourcing from a private bucket #42

Closed
3 tasks
robinmetral opened this issue May 18, 2020 · 1 comment · Fixed by #43
Closed
3 tasks

test: add e2e test case for sourcing from a private bucket #42

robinmetral opened this issue May 18, 2020 · 1 comment · Fixed by #43
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@robinmetral
Copy link
Contributor

Follow-up on #21 and #24

After resolving #24, we should add an e2e test case to make sure that sourcing from private buckets is handled properly moving forward.

We need to:

  • create a private bucket with some images to source (and document the bucket's policy for the README)
  • source them in the example Gatsby site
  • assert that it succeeds in cypress
@robinmetral robinmetral added enhancement New feature or request good first issue Good for newcomers labels May 18, 2020
@robinmetral robinmetral mentioned this issue May 21, 2020
Merged
@robinmetral
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle private buckets gatsby-uc/gatsby-source-s3
1 participant
@robinmetral