We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here is the code :
var modal = new tingle.modal({ onOpen:function () { console.log('onOpen callback is called'); } });
When you close and reopen the modal several times
modal.open(); modal.close(); modal.open(); modal.close(); modal.open(); modal.close(); modal.open();
You can see that the onOpen callback is called too many times.
When I look at the code (line 94) https://github.com/robinparisi/tingle/blob/master/src/tingle.js#L94 there is an addEventListener which is attached to the modal every time the onOpen callback is called. I think this is the origin of the issue.
addEventListener
The text was updated successfully, but these errors were encountered:
5d759c9
Hi,
Good catch! I've just published a patch on version 0.7.3.
Thanks for the detailed issue 😄
Sorry, something went wrong.
Thank you @robinparisi for your quick support
No branches or pull requests
Here is the code :
When you close and reopen the modal several times
You can see that the onOpen callback is called too many times.
When I look at the code (line 94)
https://github.com/robinparisi/tingle/blob/master/src/tingle.js#L94
there is an
addEventListener
which is attached to the modal every time the onOpen callback is called.I think this is the origin of the issue.
The text was updated successfully, but these errors were encountered: