Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contenteditable="true"? #30

Closed
eriandev opened this issue Jun 10, 2022 · 2 comments · Fixed by #36
Closed

contenteditable="true"? #30

eriandev opened this issue Jun 10, 2022 · 2 comments · Fixed by #36

Comments

@eriandev
Copy link
Contributor

I know it's a small thing, but I want to know why rendered SVGs are added contenteditable="true"?
All SVG properties should be chosen by the user and not have things that are not necessary by themselves.
@robinscholz
Copy link
Owner

@eriandev Sorry for the late reply.

I originally wrote the package for a very specific use case before open sourcing it, this is a leftover from back then. Feel free to send a pull request to make this optional.

@CaptinKraken CaptinKraken mentioned this issue Sep 16, 2022
Merged
@artemjackson
Copy link

Hey @robinscholz 👋 Kindly reminding, please check the PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove contenteditable CaptinKraken/svelte-inline-svg
3 participants
@artemjackson @eriandev @robinscholz