Fix prefixing for grid-column/row-span #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robinweser @lencioni Hello there! Would you please review this when you have time? |
|
I'm confused why ms is a special case for this package. I'm wondering if the root problem you are seeing is somewhere else? |
|
@etripier Hmm. Seems more like an issue with the underlying styling library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that using an integer value for
msGrid(Column|Row)Spancauses the style to be interpreted as a unitless length value, which means it ends up as${value}pxinstead of just${value}. Unfortunately, that's not what we want - we expect this to refer to a line position on the grid.I also took the opportunity to fix #176, although I think the conditions for producing that error are far off the beaten path.