Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Chrome support for cursor: grab #79

Closed
alexyaseen opened this issue May 16, 2016 · 3 comments · Fixed by #82
Closed

Incorrect Chrome support for cursor: grab #79

alexyaseen opened this issue May 16, 2016 · 3 comments · Fixed by #82

Comments

@alexyaseen
Copy link
Contributor

As far as I can tell, cursor.js is checking for chrome < 37 to decide whether to prefix 'grab' and 'grabbing'. However, even on Chrome 50 I'm seeing the need to still prefix 'grab' and 'grabbing'.

@robinweser
Copy link
Owner

Do you have any information which browser need prefixes for grab and grabbing?
I can't find any serious links and as it seems caniuse.com now only list zoom-in and zoom-out which had the grab and grabbing listed within the same group before.
Seems like we need a new plugin in that case.

@alexyaseen
Copy link
Contributor Author

alexyaseen commented May 17, 2016

I haven't found a reliable source for which browser needs the prefixes. I'm seeing the same as you on caniuse.com. Always prefixing those values might not be a great approach, but perhaps better than nothing for now?

If that's what you want to do for now, I'm happy to make a pull request if you'd like.

@robinweser
Copy link
Owner

Yeah I guess that would be great, we should have both plugins. One for zoom-in / zoom-out one for those grab cursor. Waiting for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants