Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload only if setting is modified #25

Closed
wants to merge 1 commit into from
Closed

Reload only if setting is modified #25

wants to merge 1 commit into from

Conversation

stegrams
Copy link

Prevent the needles reload when a setting remains unchanged after mouse clicks out of the field.
I have also

  1. Added a folder jscss-source with the unminified versions of the css and js chunks from index.php.
  2. Changed the version to 2.0.3

I left the release and README.md unchanged because it contains the path to the latest release in @robiso repo.

@robiso
Copy link
Collaborator

robiso commented Apr 20, 2017

Hello stemgrams, thanks for this but there are a few of reasons why I won't be able to merge this, let me explain.

  • we used to have a bunch of different files such as extra admin css or js, but the direction for now is to keep everything in index.php as our core, without additional files as we're trying to be the "smallest" CMS
  • changing the version number on the public repo causes a notification to go out to all WonderCMS users and shows the "update" button to overwrite/update WonderCMS files from this repo
  • for version 2.0.3, the plan is to push a couple of bug fixes

I would like to thank you for your contribution, I personally like the idea the settings being modified only if a change has been made, but don't see this as a critical update and would rather see it gets thoroughly tested in multiple environments.

@stegrams
Copy link
Author

That's fine @robiso.

By the way, the extra files are not linked with index.php. They are there just for referencing reasons and represent the minified code inside index.php that actually does the job.
The version changing was not the main purpose for this pr. It was a last minute decision that I felt it would helped. Now I see clearly it doesn't.

Anyway, really like WonderCMS. Thanks for sharing!

@robiso
Copy link
Collaborator

robiso commented Apr 20, 2017

I didn't notice, I apologize and thank you for the explanation.

Gladly to share for many more years!

Do you mind answering a couple of questions regarding your code?
Do you see any downsides to using this by default? I'm thinking of scenarios where things could go "wrong" or cause any conflicts with plugins if we include it.

Have you tried out this mechanism with any of the WYSIWYG editors?

  • some editors do not refresh pages after clicking out of the content

@stegrams
Copy link
Author

stegrams commented Apr 20, 2017

Hmm, as I see MediumEditor on save throws an error even though changes are saved successfully.
In fact plugins weren't a concern at all. I will try study the full codebase in order to have the whole image and probably come back with a more relative pr.

I appreciate the time you spend for this review.

@stegrams stegrams closed this Apr 20, 2017
@robiso
Copy link
Collaborator

robiso commented Apr 20, 2017

Thank you again for taking the time to develop and test this. Looking forward to collaborating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants