Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select the number of harmonics in the TBATS model #942

Closed
MMenchero opened this issue Jun 20, 2023 · 3 comments
Closed

Select the number of harmonics in the TBATS model #942

MMenchero opened this issue Jun 20, 2023 · 3 comments

Comments

@MMenchero
Copy link

I’ve been reviewing the code of the TBATS model and found that the approach based on multiple linear regression to select the number of harmonics in the TBATS model is no longer implemented. This approach is described in De Livera et al. (2011) and in this paper, the authors say that the multiple linear regression approach

is preferred over letting $k^*_i = 1$ for each component since the latter was found to be unnecessarily time consuming.

Could you please provide some clarification on why this approach was removed? For reference, here’s a fork where the multiple linear regression approach appears but it's not used (lines 93-114)."

@robjhyndman
Copy link
Owner

No idea. That code has been commented out for more than 10 years, and presumably was part of the code originally written by Alysha De Livera who was a PhD student working with me.

@MMenchero
Copy link
Author

Thank you for your response. I'll try to get in touch with Alysha since I'm working on an implementation of the BATS and TBATS models in Python.

@robjhyndman
Copy link
Owner

robjhyndman commented Jun 21, 2023

There are at least three existing python implementations which might be helpful:

I've not used any of these. Also, the current R implementation in the forecast package is not particularly good. We plan to rewrite it from scratch for the fable package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants