When execute command seed:run, insert all data to a table in a bulk.

[kenzo0107]

When execute command seed:run, insert all data to a table in a bulk.
It take much time to insert data to a table one by one until now.

An example is shown below:

$table = $this->table('users');
$table->bulk()
      ->insert($data)
      ->save();

It became more than triple as fast by Bulk Insert when inserting 1,000 records.
It is very effective when many data samples are required.

However, it is assumed that the keys of data to be set are unified.
The method bulk() are not available in the following example:

$data = array(
    array(
        'column1' => 'value1',
        'column2' => 1,
    ),
    array(
        'column1' => 'value2',
        'column3' => 'foo',
    ),
    array(
        'column1' => 'value3',
        'column2' => 3,
        'column3' => 'foo',
    )
);

$table = $this->table('users');
$table->bulk()
  ->insert($data)
  ->save();

The function of dynamically checking the key of the set data is not added,
because it will cause performance degradation.

[lorenzo]

Is there a way you can implement this without adding the bulk flag? I'm not sure it makes for a good API

[lorenzo]

I don't understand what this flag is for

[kenzo0107]

This flag is prepared to judge whether to use the bulk insert function.

[lorenzo]

Why not always use it?

[kenzo0107]

I see.
There is a way I can implement this without adding the bulk flag.
Thx.

[chinpei215]

aFlat

Typo?

[kenzo0107]

Oh, typo !
fix it !

[chinpei215]

Why don't you use a Closure? Phinx seems to require PHP >= 5.4. And if you use a closure, $objTmp is unnecessary, as it can inherit variables form the parent scope by reference. And $rows would be a two-dimensional array. You need not handle it recursively. If I were you, I would use foreach in this case:

$vals = [];
foreach ($rows as $row) {
   foreach ($row as $v) {
       $vals[] = $v;
   }
}

Also, I think you should make sure that all rows have the same keys. I think it doesn't make a big impact on performance, but dose prevent users' mistakes.

[kenzo0107]

Thank you for your review !

I tried to simply coded in one line.
But there was not enough consideration to Phinx.

Fix it !

Thx.

[kenzo0107]

@lorenzo

I could implement Bulk Insert without adding the bulk flag 🤓
Please review.

[lorenzo]

I think the only thing this is missing is tests showing that the method actually works

[kenzo0107]

@lorenzo

Thank you for review !

I added to test the new method with the following method.

• tests/Phinx/Db/Adapter/TablePrefixAdapterTest::testInsertData
• tests/Phinx/Db/TableTest::testInsertSaveData
• tests/Phinx/Migration/AbstractMigrationTest::testInsert

Is it necessary elsewhere ?

[lorenzo]

@kenzo0107 I didn't see any tests where the method was actually used. Only mocked tests were used, so the actual implementation is not tested

[kenzo0107]

@lorenzo Thank you for your review. I added some tests where the method is actually used.
Please review again.

[lorenzo]

Thanks @kenzo0107 !

[lorenzo]

@kenzo0107 Would you mind sending another pull request with a short example for the docs?

[kenzo0107]

@lorenzo Thank you 😄 I will send another pull request soon.