Better reversible migrations #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables otherwise irreversible migrations to become reversible, and makes it possible to use a single migration where previously two were required.
lorenzo
requested changes
Sep 3, 2017
| @@ -66,6 +66,11 @@ | |||
| protected $input; | |||
|
|
|||
| /** | |||
| * @var bool | |||
| */ | |||
| protected $goingUp; | |||
There was a problem hiding this comment.
This would not be a boolean or be accurate when using the up and down methods, would it?
|
No, but you move the setter call up so it would. It seemed superfluous.
|
|
It does seem superfluous, but it is not. Having the state of an object consistent is important because you don't know the different permutations a particular object can be used |
|
So should I close the #788 ? |
|
@mvrhov yes |
|
Thanks! |
|
@lorenzo I know you already merged but? Wouldn't it be better if |
|
@mvrhov Sure, it like that.. care to open a new PR with the change? |
|
Sorry I don't have time :/ Maybe @Roy-Orbison can find some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables otherwise irreversible migrations to become reversible, and makes
it possible to use a single migration where previously two were required.
Pursuant to #1151