Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate unneeded new wrappers. #49

Closed
typesupply opened this issue Jul 21, 2016 · 1 comment
Closed

Don't generate unneeded new wrappers. #49

typesupply opened this issue Jul 21, 2016 · 1 comment
Assignees
@typesupply

Comments

@typesupply
Copy link
Member

Currently if we do this:

groups1 = font.groups
groups2 = font.groups

Two wrappers are generated. Try to avoid this.
typesupply added a commit that referenced this issue Jul 26, 2016
@typesupply
Do some object caching. WIP for #49.
1726221
@typesupply typesupply self-assigned this Apr 6, 2018
typesupply added a commit that referenced this issue Apr 6, 2018
@typesupply
Remove object caching.
df72b20 
his seems like a premature optimization and, even if it's not, it's a
clumsy way to handle caching. It was never finished anyway. This
addresses #49.
@typesupply
Copy link
Member Author

I'm going to close this as it seems like it was either a premature optimization or a hack around __eq__ not working at the time. __eq__ works now. The only objects that were cached were info, groups, kerning, features and lib. So, it doesn't seem like it was a real issue. If it comes up again I'll open a new ticket and address it there.

@typesupply typesupply mentioned this issue Apr 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@typesupply typesupply

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@typesupply