Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added edge case handling for conditional object #64

Merged
merged 2 commits into from Oct 19, 2022

Conversation

ogjaylowe
Copy link
Contributor

Description

Users were previously required to use all conditions for active learning so added edge case handling to the conditionals object in case users don't specify all possible key words.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Ran a series of unit tests with the below code snippet making sure all variations were supported including no config object, one field, all fields, some fields, value == None, etc.

from roboflow import Roboflow

rf = Roboflow(api_key="BLlkFnwfSaRFUXBfU0tJ")

upload_conditions_config = {
    "target_classes": ['helmet'],
    "confidence_interval": [30,90]
}

rf.workspace().active_learning("./test_cases", ".png", ["hard-hat-universe-0dy7t", 3], "merge_tester", upload_conditions_config)

Docs

  • Docs updated? What were the changes: Added a note in the active learning section that you don't have to use all fields.

@ogjaylowe
Copy link
Contributor Author

the make style clean up made the ternary statements look a little funky but still passes all the tests I put in.

Should I be updating unittests?

@ogjaylowe ogjaylowe requested a review from broox October 13, 2022 04:15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🚀

@FrancescoSaverioZuppichini
Copy link
Contributor

the make style clean up made the ternary statements look a little funky but still passes all the tests I put in.

Should I be updating unittests?

I like them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants