Fix for json_response["image"] in prediction.py #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue because we changed our data structure recently. The resulted in json_response["image"] not existing. Used cv2.imread to get image dimensions and reconstructed img_dims.
…oboflow-python into json-response-trt-fix
added 3 commits
January 5, 2023 17:23
Sorry for all the updates, forgot to do "make style"
Was able to pass variables from object_detection.py instead of generating in prediction.py
Ran python -m unittest a lot.
Tyler-Odenthal
requested review from
FrancescoSaverioZuppichini and
Jacobsolawetz
and removed request for
Jacobsolawetz and
FrancescoSaverioZuppichini
FrancescoSaverioZuppichini
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
LGTM, thanks @Tyler-Odenthal
For the future, don't change the version number - only change it in a self contained PR
roboflow/__init__.py
Outdated
| @@ -8,7 +8,7 @@ | |||
| from roboflow.core.project import Project | |||
| from roboflow.core.workspace import Workspace | |||
|
|
|||
| __version__ = "0.2.23" | |||
| __version__ = "0.2.24" | |||
There was a problem hiding this comment.
why the version was changed? Are you planning on a new release? It's better to make a single separate PR with the version bump to avoid overlapping with other PRs
There was a problem hiding this comment.
Noted! Appreciate the feedback!
Is this still good to push or do I need to revert the version number?
There was a problem hiding this comment.
Now you have to push it since we increase the number from another PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue because we changed our data structure recently. The resulted in json_response["image"] not existing.
Used PIL to get image dimensions and reconstructed img_dims.
No dependency changes
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested on two TRT scripts and with three different models. Have yet to test it on an edge device, but this fix should not be device specific.
Any specific deployment considerations
Reading image for image dimensions takes time, if there is a more efficient way to get img_dims or if we are already pulling dims somewhere else in the script. We should pass the variable instead of creating another variable.