Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyPoints] - extend from_mediapipe with Google MediaPipe FaceMesh #1274

Open
LinasKo opened this issue Jun 11, 2024 · 3 comments
Open

[KeyPoints] - extend from_mediapipe with Google MediaPipe FaceMesh #1274

LinasKo opened this issue Jun 11, 2024 · 3 comments
Assignees
Labels
api:keypoints enhancement New feature or request

Comments

@LinasKo
Copy link
Collaborator

LinasKo commented Jun 11, 2024

Description

Much like #1174 and #1232 adding pose landmark support, we'd also like to add face detection support to the from_mediapipe method.

facemesh

Links:

Additional

  • Note: Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will speed up the review process. The reviewer must test each change. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! 🙏🏻
@LinasKo LinasKo added enhancement New feature or request help wanted Extra attention is needed api:keypoints labels Jun 11, 2024
@LinasKo
Copy link
Collaborator Author

LinasKo commented Jun 11, 2024

Hey @David-rn,

I saw your comment regarding the lazy loader / high memory usage issue. I need to scope out that one first, but if you're keen to contribute and enjoyed the work on MediaPipe, this one is up for grabs 😉

@onuralpszr
Copy link
Collaborator

@LinasKo if not I worked face mesh before so I really want to be involved too

@LinasKo
Copy link
Collaborator Author

LinasKo commented Jun 11, 2024

Hi @onuralpszr,

Sure, we can reserve it for you - I recall you mentioning it before 🙂

However, we can afford to a wait a little bit, so I'd prefer to close the sinks and maybe the water meter cookboks first (I have some feedback to send about the latter).

@LinasKo LinasKo removed the help wanted Extra attention is needed label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:keypoints enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants