Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineZone and LineZoneAnnotator not exposed at top level #30

Closed
1 of 2 tasks
dceejay opened this issue Feb 24, 2023 · 5 comments
Closed
1 of 2 tasks

LineZone and LineZoneAnnotator not exposed at top level #30

dceejay opened this issue Feb 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@dceejay
Copy link
Contributor

dceejay commented Feb 24, 2023

Search before asking

  • I have searched the Supervision issues and found no similar bug report.

Bug

fails to expose latest LineZone changes

line_counter = sv.LineZone(start=LINE_START, end=LINE_END)
AttributeError: module 'supervision' has no attribute 'LineZone'

Environment

Supervision: 0.2.1

Minimal Reproducible Example

No response

Additional

just need to add

from supervision.detection.line_counter import LineZone, LineZoneAnnotator

to top level init.py

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@dceejay dceejay added the bug Something isn't working label Feb 24, 2023
@github-actions
Copy link
Contributor

Hello there, thank you for opening an Issue ! 🙏🏻 The team was notified and they will get back to you asap.

@SkalskiP
Copy link
Collaborator

Hi, @dceejay 👋🏻! Thanks a lot for pointing that out. Would you like to submit a PR with that change?

@dceejay
Copy link
Contributor Author

dceejay commented Feb 24, 2023

ok - done.
also I note the annotator .annotate method is somewhat different to the zone one... not sure if they could be made more similar ?

@SkalskiP
Copy link
Collaborator

Yup. We actually plan to redesign our annotators. So it is on our TODO list for the near future.

@SkalskiP
Copy link
Collaborator

PR is merged. I'm closing the issue. Thanks for help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants