Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repo] Should we use types and check with mypi? #4

Open
FrancescoSaverioZuppichini opened this issue Aug 9, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@FrancescoSaverioZuppichini
Copy link
Contributor

We can decide if it makes sense for us to force ourself to use types hints and check them with mypi

@FrancescoSaverioZuppichini FrancescoSaverioZuppichini added the enhancement New feature or request label Aug 9, 2022
@paulguerrie
Copy link
Collaborator

I don't have super strong opinions about this but sometimes it feels like they can get in the way of rapid development. And since they aren't enforced in any way, they are essentially just code comments which can be hard to keep up to date when used extensively.

On the flip side, I can see how it makes code a lot easier to read.

@FrancescoSaverioZuppichini
Copy link
Contributor Author

I feel the same. One thing that is kinda of not so nice is when you are using packages that are not mypi friendly, then you have to tell him to not check them etc.

Probably we can agree upon using them for function/methods parameters/returns to make it easier sharing code between us.

Looking forward to hear @Jacobsolawetz opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants