Remove SandboxClassLoader.getPackage override #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-robolectric
force-pushed
the
piper_322810667
branch
2 times, most recently
from
4a472d6
to
c176ef2
Compare
This override appears to be obsoleted by #5036, and all tests still pass without the overridden method. This fixes the error when running a Robolectric test with Java 11: WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.robolectric.util.ReflectionHelpers$6 to method java.lang.ClassLoader.getPackage(java.lang.String) PiperOrigin-RevId: 322810667
copybara-robolectric
force-pushed
the
piper_322810667
branch
from
c176ef2
to
7a7da8c
Compare
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove SandboxClassLoader.getPackage override
This override appears to be obsoleted by #5036, and all tests still pass
without the overridden method.
This fixes the error when running a Robolectric test with Java 11:
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.robolectric.util.ReflectionHelpers$6
to method java.lang.ClassLoader.getPackage(java.lang.String)