Remove UnsafeAccess.getJavaVersion #5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-robolectric
force-pushed
the
piper_323873990
branch
3 times, most recently
from
fc42ef3
to
ca4094d
Compare
hoisie
changed the title
copybara-robolectric
force-pushed
the
piper_323873990
branch
2 times, most recently
from
f5f26ea
to
85ad610
Compare
Use Utils.getJavaVersion instead. Although this does introduce an awkward dependency from :utils:reflector to :utils, there is no dependency cycle, as :utils does not depend on :utils:reflector. This also reinforces the need to have common Java version parsing logic (i.e. #5577). Once we have that we can drop the :utils:reflector -> :utils dependency. PiperOrigin-RevId: 323873990
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Utils.getJavaVersion instead. This introduces a dependency from
:utils:reflector to :utils, and removes the dependency between :utils and
:utils:reflector.
This also reinforces the need to have common Java version parsing logic (i.e.
#5577). Once we have that we can drop the :utils:reflector -> :utils
dependency.