Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all authentication results for BiometricManager #7214

Closed
utzcoz opened this issue Apr 5, 2022 · 1 comment
Closed

Support all authentication results for BiometricManager #7214

utzcoz opened this issue Apr 5, 2022 · 1 comment
Labels
help wanted starter issue Small/simple issues for new contributors

Comments

@utzcoz
Copy link
Member

utzcoz commented Apr 5, 2022

Description

BiometricManager has multiple authentication result:

  1. BIOMETRIC_ERROR_HW_UNAVAILABLE.
  2. BIOMETRIC_ERROR_NONE_ENROLLED.
  3. BIOMETRIC_ERROR_NO_HARDWARE.
  4. BIOMETRIC_ERROR_SECURITY_UPDATE_REQUIRED.
  5. BIOMETRIC_SUCCESS.

But Robolectric only supports following results for int canAuthenticate() for Android Q:

  1. BIOMETRIC_SUCCESS.
  2. BIOMETRIC_ERROR_NO_HARDWARE.
  3. BIOMETRIC_ERROR_HW_UNAVAILABLE.

And Robolectric also only supports following results for int canAuthenticate(int userId, int authenticators) from Android R:

  1. BIOMETRIC_SUCCESS.
  2. BIOMETRIC_ERROR_NO_HARDWARE.

There are some tests need to use all authenticate result, e.g. androidx's BiometricManagerTest.

Steps to Reproduce

See above.

Robolectric & Android Version

Latest Robolectric master branch.

Link to a public git repo demonstrating the problem:

Robolectric itself.

@utzcoz utzcoz added help wanted starter issue Small/simple issues for new contributors labels Apr 5, 2022
@utzcoz utzcoz changed the title Support all authentication result for BiometricManager Support all authentication results for BiometricManager Apr 5, 2022
@utzcoz
Copy link
Member Author

utzcoz commented Sep 24, 2022

Fixed by #7427.

@utzcoz utzcoz closed this as completed Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted starter issue Small/simple issues for new contributors
Projects
None yet
Development

No branches or pull requests

1 participant