Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rdio-scanner plugin does not send the freq_list with spike_count and error_count #602

Open
chuot opened this issue Jan 7, 2022 · 2 comments

Comments

@chuot
Copy link
Contributor

chuot commented Jan 7, 2022

I just realized that the rdioscanner-plugin does not send the freq_list with the number of spikes and errors in the frequency field, so Rdio Scanner always shows "E: 0 S: 0" instead of the proper data.

I am however a little confused on how to bring this data to the uploader. What would be the right way to do this, add the information in Call_Data_t?

@aaknitt
Copy link
Contributor

aaknitt commented Jan 9, 2022

Looks like when the plugin system was put in place that info didn't make it into the JSON in the same way that it used to be either:
4daac16#diff-27578a9e34f9eb8cfcc62585171ceb71273ff44aa16f05c5f51e40322e58f2f3

So there is a freqList object available in the JSON file but it's not actually getting populated with all of the data from the freq_list. Error Count and Spike Count look like they're hard-coded to zero and only one frequency is making it in there, the list isn't being accessed and looped through to populate the JSON data.

I think you're correct that the freq_list information needs to get added to the Call_Data_t structure and then populated in call_concluder.cc. The JSON generation should also loop through that same info to pull out everything from the list so that it's available there in addition to via the plugin system.

@taclane
Copy link
Contributor

taclane commented Mar 31, 2022

Changes in the recent no-overlap branch have allowed plugins to see errors and spikes. Commits to this branch should already provide rdio-scanner with correctly-formatted json files if using upload scripts.

#660 should patch the ability into the rdio-scanner plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants