Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silenceFrames got switched back to idleSilence at main.cc#465 #647

Closed
rosecitytransit opened this issue Mar 8, 2022 · 2 comments
Closed

silenceFrames got switched back to idleSilence at main.cc#465 #647

rosecitytransit opened this issue Mar 8, 2022 · 2 comments

Comments

@rosecitytransit
Copy link
Contributor

https://github.com/robotastic/trunk-recorder/blob/master/trunk-recorder/main.cc#L465

happened in 7069881

idleSilence doesn't appear anywhere else in the code

(this is a fix I originally committed with #456 / #470 )
@robotastic
Copy link
Owner

Weird! I don't know why that snuck in there... thanks for catching it!

@rosecitytransit
Copy link
Contributor Author

You're welcome. Also, I'm not sure it's listed in the configuration docs, though I don't know this option is really useful anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robotastic @rosecitytransit