Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues I'd like to (see) address(ed) #2 #812

Open
9 of 30 tasks
rosecitytransit opened this issue May 12, 2023 · 0 comments
Open
9 of 30 tasks

Issues I'd like to (see) address(ed) #2 #812

rosecitytransit opened this issue May 12, 2023 · 0 comments

Comments

@rosecitytransit
Copy link
Contributor

rosecitytransit commented May 12, 2023

Having gotten back into playing/messing with trunk-recorder, this is a follow-up to #456 and is list I've been keeping/adding to myself

  • remove duplicate #include <errno.h> in lib/op25_repeater/lib/p25_frame_assembler_impl.cc
  • "tbsk" typo in p25_parser.cc
  • emergency flag (cc and calls)
  • create configure.md entry for logDir option
  • create configure.md entry for controlRetuneLimit option
  • create configure.md entry for silence frames, make boolean (should do "real time" recording by including the silence frames that terminators, etc are attached to)
  • fix unitScript configure.md entry (something about talkgroups?)
  • remove white space at end of lines/spaces before tabs
  • add pause to create_call_json in call concluder to wait for compress_wav to finish
  • remove duplicate add_file_log (fix Create log file earlier #754), move it up so "Using Config file"..."Log Directory" lines make it into them
  • option to disable BOOST logging to console (since there's also the log files option)
  • make priority levels work more logical (e.g. allow preemption when a lower-numbered priority call comes in and there's no recorder available, have a level setting above which talk groups are never recorded)
  • have a priority level setting that is given to unknown talkgroups, instead of just the blanket record/ignore option
  • add line break to chan update log messages (issue is that a single update message can contain 2 entries)
  • possibly add message.source == call->talkgroup checking 0eb05cd
  • possibly add TG/freq == 0 checking bbbaa6c (but like 55cc8b0 instead; I'm getting calls for 769.000000; is that a valid frequency on any system?)
  • BOOST_LOG_TRIVIAL(info) << "stopping flow graph" << std::endl; (?)
  • move unknown message logging from p25_parser to main so the system name can be added (or is there a way to get the system name in p25_parser? Right now all of those messages don't include where they came from)
  • add a flag to log lines that are control channel messages (not about calls or other trunk-recorder actions)
  • combine channel grant and update routines
  • move patch info logging from rate check to status message (it creates repetitive log lines every 3 seconds now)
  • debug log newly seen patches rosecitytransit@0c1610e
  • only do add_internal_plugin if plugin is set in config.json
  • remove the freqList line from JSON creation (see OpenMHz Uploader update #794)
  • possibly remove the talkgroup_tag / _description / _group_tag / _group lines from JSON as consumers should be looking that stuff up in the channel list.
  • remove rx_status.last_update that I added as I don't use it anymore
  • change default for callLog option in code
    system->set_call_log(node.second.get<bool>("callLog", true));
    to match the false stated in configure.md
  • perhaps make USRP support optional ( 031ffcc )
  • possibly a tiny version of trunk-recorder with all call functions removed, for testing location/device/settings/antenna quality based on control channel decoding rate
  • possibly implement maxDuration for trunked calls (only does conventional now; would stop stuck calls)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant