Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tree Node Should *" keywords should have the jemmy timeout as optional argument #77

Closed
tarand opened this issue Oct 26, 2015 · 1 comment

Comments

@tarand
Copy link

tarand commented Oct 26, 2015

Looking at all those "Tree Node Should'" keywords: The is only two of them (Tree Node Should Be Leaf and Tree Node Should Not Be Leaf) which explicitly state the need to call "Set jemmy timout" in order to shorten test execution time. I guess that for all the others the same remark is valid. It would also be very helpful, if the kind of time (e.g. JTreeOperator.WaitNodeExpandedTimeout) that must be specified is added.
I would also suggest to add a parameter "timeout=None" in all the arguments. If passed, it should call set jemmy timeout (with the correct type for this call) automatically (and reset it back before returning of course),

This would avoid the following code that I have to add at many places:

${old}= | Set Jemmy Timeout | ...
Tree Node Should * ...
Set Jemmy Timeout | ${old}

Note also that this code even is not correct! If the Tree Node Should* keyword should fail, the timeout is NOT reset, which could cause bad test results for other testcases as a consequence. (Please note how difficult it would be to correct this issue).

@WojtekKowaluk
Copy link
Contributor

This sounds like good idea, I will check how hard it would be to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants