New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when long-pressing a folder #11

Open
HenryHu opened this Issue Feb 28, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@HenryHu

HenryHu commented Feb 28, 2013

Crash on Nexus 4, ACV 1.4.1.4:

  1. start the app
  2. click menu
  3. choose "open"
  4. go to directories like /mnt
  5. long-press a folder, like "secure"
  6. crash

The reason is that, when you don't have permission, File.list() would return null. But this is not checked. The problem happens in src/net/robotmedia/acv/ui/SDBrowserActivity.java:111, where you called file.list() and later used the result. The return code may be null.

In this case, it's due to permission, so maybe it's not that interesting. However, it may also return null due to other reasons. Anyway, showing an error message is better than crashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment