Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requst: Download Product automatically if not available #52

Closed
BobDG opened this issue Feb 20, 2014 · 4 comments
Closed

Feature Requst: Download Product automatically if not available #52

BobDG opened this issue Feb 20, 2014 · 4 comments
Labels

Comments

@BobDG
Copy link

BobDG commented Feb 20, 2014

Now when I try to make an In-App Purchase and the product hasn't been requested yet it returns with an error.
I believe it would be really nice if it doesn't have the product yet it automatically requests it first and then proceeds to the purchase automatically.

Otherwise I have to always check if the product is available or not in RMStore before trying the addPayment...

@hpique
Copy link
Member

hpique commented Feb 20, 2014

Hi @bobmp. Thanks for contributing.

I think StoreKit is meant to load all products at startup, or as soon as you're able.

In any case, combining both operations into one would complicate the code you add to the failure block, as you would have to deal with two more cases: RMStore failed to load the product, and the product identifier is invalid (which would require to add an additional parameter to the error).

I believe the current API makes error handling simpler. So unless someone makes a strong case about this feature, I don't think it should be part of RMStore.

@hpique hpique added the wontfix label Feb 20, 2014
@BobDG
Copy link
Author

BobDG commented Feb 20, 2014

Hi,

I do kind of agree with you, but I have this problem here. As soon as the user starts my app, he can immediately purchase the In-App Purchase. With 1 tap. So if I start loading the product and the user taps on the purchase before the product request is done, it will fail. But I guess perhaps I should rethink my app or simply keep the product-check I've implemented already.

@hpique
Copy link
Member

hpique commented Feb 20, 2014

What's preventing your from loading the products on the 1 tap? And then initiating the purchase on the success block? The user doesn't have to know what's going on under the hood.

@BobDG
Copy link
Author

BobDG commented Feb 20, 2014

Yes that's what I do now. I check if I have the product or not, if not, download it, if I do, start purchase. I just don't like it that I have 2 blocks after each other now :)

@BobDG BobDG closed this as completed Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants