Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

Add tooltips to each device #17

Open
virtuald opened this issue Apr 8, 2015 · 4 comments
Open

Add tooltips to each device #17

virtuald opened this issue Apr 8, 2015 · 4 comments
Assignees

Comments

@virtuald
Copy link
Member

virtuald commented Apr 8, 2015

pyfrc enables this functionality via sim/config.json. It's not super extensible -- so we should change the JSON so that its usable from both pyfrc and websim. Right now, all pyfrc data is read from the 'pyfrc' key -- websim should not do this, nor should it have its own key.

A sample configuration?

{ 
    "joysticks": {
            "0": {
                "show": true,
                "axes": {
                    "X": "Strafe",
                    "Y": "Back/Forth"
                },
                "buttons": {
                    "1": "Reverse Direction",
                    "2": "Can Down",
                    "3": "Can Up",
                    "6": "Can Top",
                    "7": "Can Bottom"
                }
            },
        }
       "pwm": {
            "0": "Left Front",
            "1": "Left Rear",
            "2": "Right Front",
            "3": "Right Rear"
        },
    }

I'm not convinced that it's totally a good idea to do it this way, I'm open to something more flexible.

@amorygalili
Copy link
Contributor

done

@amorygalili
Copy link
Contributor

Websim currently doesn't have any tooltips. Do you think the websim and pyfrc sim need to share the same config @virtuald ? Currently the config is under its own "websim" key, the naming is different (e.g. "w" is "width", "starting_x" is "startingX"), and I plan on it having plenty of physics related configuration options the pyfrc sim does not have.

@amorygalili amorygalili reopened this Jan 3, 2019
@virtuald
Copy link
Member Author

virtuald commented Jan 4, 2019

For settings that are the same, it seems that it would be nice to have them match because backwards compatibility?

@amorygalili
Copy link
Contributor

Do you think the configuration should still be under "pyfrc" for the sake of backwards compatibility? I guess I should allow for both "pyfrc" and "websim", that seems to make sense to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants