Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to Finch HTTP client #12

Closed
balexand opened this issue Oct 23, 2022 · 2 comments
Closed

Consider switching to Finch HTTP client #12

balexand opened this issue Oct 23, 2022 · 2 comments

Comments

@balexand
Copy link

balexand commented Oct 23, 2022

Thanks for creating this awesome library. Would you consider switching the HTTP client from httpoison to finch? Reasons include:

If you're open to this then I'd be happy to submit a pull-request updating the Meilisearch.HTTP to use Finch. Thanks.

@Calamari
Copy link
Contributor

Hey @balexand. The current master now contains a version that uses Finch. Check this out, and if you got further great feedback. I am all ears :-)

@balexand
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants