Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of a 'wip' branch #39

Closed
ghost opened this issue Sep 8, 2019 · 2 comments
Closed

Lack of a 'wip' branch #39

ghost opened this issue Sep 8, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 8, 2019

Not only would it be useful to commit changes to there rather than straight to master, it's also already covered in documentation (see CONTRIBUTING.md) but was apparently deleted? Regardless, it would definitely be a useful addition for development.

@roboyoshi
Copy link
Owner

Yes I deleted it, because I felt the exact opposite. Having a develop/wip branch is typical for software-dev (Classic Git Flow), but I don't see why it would be necessary here? When someone creates a PR and it's accepted, then it's pretty much approved and can be released to the public right away. So I changed it to master only. There are other branches for certain features, but I don't feel like changing it back.

@ghost
Copy link
Author

ghost commented Sep 8, 2019

Ah ok, fair enough. I can kind of see now why it wouldn't really be necessary. Thanks for explaining.

@ghost ghost closed this as completed Sep 8, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant