-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
div.row > div.six.columns
(or other sizes) doesn't seem to break to block (100%) on Safari iOS
#8
Comments
Hmm. Can you post a small example with this behavior? I'll add it to the CBT tests and figure out what's going on. |
@robsheldon could you test it on Android or you had this behavior before? |
I hadn't seen this behavior in previous device tests. I suspect there's some combination of html and the css that's causing this. I need to figure out the html part. I'll make time for it tomorrow at the latest. |
@robsheldon to me it's an @media issue, more specifically Even the official website has the same (bugged) behavior. |
Seems to be an iOS issue as I said, ported from Miligram ( milligram/milligram#136 ). My fix was replacing the @media screen and (max-width: 639px) {
.row {
flex-direction: column;
}
.column, .columns {
width: 100% !important;
margin: 0 !important;
padding: 0 !important;
}
} Edit: |
Thank you for doing so much leg-work on this issue. I do want to fix it, my hang-up has been on finding the right approach for it. The media queries are given in rem units to help improve support for environments with scaled displays -- some people with poor eyesight may have browser options set to scale things and using rems supports that better than px. I'm reluctant to just bump the max-width on that media selector from 40 to 45rem because there are still going to be a handful of handheld devices with this behavior. I think the right thing to do is to switch to using device-width and pixels, but that's not a change I want to make in a point update. So, I'm going to do a bugfix release for the other two bugs that have been reported, and then see if changing up the media queries is going to break anything. If not, I'll do a minor release with that fix. |
I designed / coded a page and in Chrome it's fine (tested using the responsive mode, aka device toolbar), but when I use on my actual phone, the
div.row > div.six.columns
doesn't seem to ocupy 100% of the width, breaking the whole viewport :( is it because of the@media
queries usingppi
instead of pixels? (@media only screen and (max-resolution: 119dpi) and (min-resolution: 91dpi), not all html
)The text was updated successfully, but these errors were encountered: