Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Node 4.2.2 #4

Open
lstanden opened this issue Dec 8, 2015 · 3 comments
Open

Issues with Node 4.2.2 #4

lstanden opened this issue Dec 8, 2015 · 3 comments

Comments

@lstanden
Copy link

lstanden commented Dec 8, 2015

Just tried to run one of the examples in Node 4.2.2 and ran into this issue:

Welcome MyApp console[cluster.Master]

  (0) worker actives


Hint: use cmds() to print the current exports available to you

function (preserveCursor) {
  if (this.paused) this.resume();
  if (this.terminal) {
    if (!preserveCursor) this.cursor = 0;
    this._refreshLine();
  } else {
    this._writeToOutput(this._prompt);
  }
}cmds()

Reproduction steps:

  • Install Node v4.2.2
  • git clone replr repo
  • npm install
  • node examples/netcat.js
  • connect via netcat/telnet

This occurs with the server.js as well, however the reproduction there is to connect using the replr client as instructed. All of them output the above function code instead of a prompt.

@lstanden
Copy link
Author

lstanden commented Dec 8, 2015

Note the cmds() above was what I tried to enter. No output was returned.

Edit: Isolated this to class InputInterceptor extends Transform. Replacing the lines which add this InputInterceptor with a straight up socket get the REPL working normally again.

@lstanden lstanden changed the title Issues Broken Node 4.2.2 Issues with Node 4.2.2 Dec 8, 2015
@lstanden
Copy link
Author

lstanden commented Dec 8, 2015

      replOptions.input = socket;
      //replOptions.input = new InputInterceptor({
      //  client: this,
      //  socket: socket
      //});

The above changes get the REPL working fine for me in Node 4.2.2.

The function is still printed the first time (instead of a prompt), however the REPL actually works fine.

@robskillington
Copy link
Owner

Thanks for reporting @lstanden, let me install 4.2.2 and check this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants