Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File.asPath #166

Closed
robstoll opened this issue Oct 2, 2019 · 2 comments
Closed

File.asPath #166

robstoll opened this issue Oct 2, 2019 · 2 comments
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 2, 2019

Platform (jvm, jdk8, js, android): jdk8

Code related feature

expect(File("my.txt")).asPath()
expect(File("my.txt")).asPath {
   //...
}

Following the things you need to do:

api

  • create a new file fileAssertions.kt in the same folder as pathAssertions (in the jdk8 extension)
  • provide a val which returns Expect (use File.toPath and see asIterable in sequenceAssertions as a guideline)
  • provide a fun which expects an assertionCreator-lambda for Path and returns Expect (see asIterable in sequenceAssertions as a guideline)
  • bonus write a separate Spec named FileFeatureAssertionsSpec in specs-common (see for instance CollectionAssertionsFeatureAssertionsSpec) and extend it in atrium-api-fluent-en_GB-common/src/test
    => this is not strictly required as we only delegate

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@lelloman
Copy link
Contributor

lelloman commented Oct 3, 2019

I'll work on this

@robstoll
Copy link
Owner Author

robstoll commented Oct 6, 2019

Implemented by bb9cc51

@robstoll robstoll closed this as completed Oct 6, 2019
@robstoll robstoll added this to the 0.9.0 milestone Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants