Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite :readme-examples from spek to junit5 #1681

Open
robstoll opened this issue Jan 26, 2024 · 0 comments
Open

rewrite :readme-examples from spek to junit5 #1681

robstoll opened this issue Jan 26, 2024 · 0 comments

Comments

@robstoll
Copy link
Owner

robstoll commented Jan 26, 2024

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

the readme-example project executes tests and write the output of the failure into the README.md of Atrium. It is based on Spek and since Spek doesn't advance, has bugs which makes it impossible for Atrium to upgrade respectively, we should move away from spek entirely. This includes also the readme-example project. Instead of providing an own TestEngine (which uses SpekTestEngine) we should write just normal tests and use a TestExecutionListener or similar (something which is able to turn a failing test into a successful one and vice versa) to achieve the same.

This isn't a good first issue but might be fun to tackle. In the end, executing ./gradlew :readme-example:build should generate the same output in README.md (see for instance <ex-first> in README.md and the corresponding FirstExampleSpec

Once we don't rely on spek, we can also update junit #1677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant