Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version (0.21.0) fails in Windows 11 64bit stable #54

Closed
reddyshyam opened this issue Sep 4, 2023 · 3 comments
Closed

Latest version (0.21.0) fails in Windows 11 64bit stable #54

reddyshyam opened this issue Sep 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@reddyshyam
Copy link

Throws below error on command line

mudslide.exe login
node:internal/modules/cjs/loader:933
const err = new Error(message);
^

Error: Cannot find module './718.index.js'
Require stack:

  • C:\snapshot\dist-ncc\index.js
  1. If you want to compile the package/file into executable, please pay attention to compilation warnings and specify a literal in 'require' call. 2) If you don't want to compile the package/file into executable and want to 'require' it from filesystem (likely plugin), specify an absolute path in 'require' call using process.cwd() or process.execPath.
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function._resolveFilename (pkg/prelude/bootstrap.js:1951:46)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at Module.require (pkg/prelude/bootstrap.js:1851:31)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.require (C:\snapshot\dist-ncc\index.js)
    at C:\snapshot\dist-ncc\index.js
    at Array.reduce ()
    at Function.e (C:\snapshot\dist-ncc\index.js) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [ 'C:\snapshot\dist-ncc\index.js' ],
    pkg: true
    }
@reddyshyam reddyshyam changed the title Latest versions fails in Windows 11 64bit stable Latest version (0.21.0) fails in Windows 11 64bit stable Sep 4, 2023
@robvanderleek robvanderleek self-assigned this Sep 5, 2023
@create-issue-branch
Copy link

@robvanderleek robvanderleek added the bug Something isn't working label Sep 5, 2023
@robvanderleek
Copy link
Owner

Hi @reddyshyam

This seems to be an issue with the bundler (ncc) and the packager (pkg) I'm using.
A summary of my understanding: the packager does not support ESM modules (that some of the third-party libraries from Mudslide use), so I first need to bundle everything using CommonJS modules. However, the bundler generates dynamic require statements that are problematic for some platforms.

I've now explicitly added all the JS files to the Windows in binary, maybe that helps. I don't have access to a Windows platform so please try the 0.21.1 release and let me know.

@reddyshyam
Copy link
Author

Hi @reddyshyam

This seems to be an issue with the bundler (ncc) and the packager (pkg) I'm using. A summary of my understanding: the packager does not support ESM modules (that some of the third-party libraries from Mudslide use), so I first need to bundle everything using CommonJS modules. However, the bundler generates dynamic require statements that are problematic for some platforms.

I've now explicitly added all the JS files to the Windows in binary, maybe that helps. I don't have access to a Windows platform so please try the 0.21.1 release and let me know.

Works like a charm👌though exe has become bulky but understandable. Thanks for the quick resolution. 🙏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants