Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test test_validate_docset_params_1_into_args is failing #42

Closed
antifuchs opened this issue Sep 20, 2022 · 2 comments · Fixed by #43
Closed

Test test_validate_docset_params_1_into_args is failing #42

antifuchs opened this issue Sep 20, 2022 · 2 comments · Fixed by #43

Comments

@antifuchs
Copy link
Contributor

Describe the bug
I was trying to install cargo-docset via a method that runs tests before installation and noticed that the test test_validate_docset_params_1_into_args is failing.

To Reproduce
cargo test in the crate root

Expected behavior
Tests succeed.

Screenshots

running 5 tests
test tests::test_default_docset_params_into_args_is_empty ... ok
test tests::clap_verify_cli ... ok
test tests::test_validate_matches_docset_params_1 ... ok
test tests::test_validate_docset_params_1_into_args ... FAILED
test tests::test_parse_docset_params_1 ... ok

failures:

---- tests::test_validate_docset_params_1_into_args stdout ----
thread 'tests::test_validate_docset_params_1_into_args' panicked at 'assertion failed: cargo_doc_args.is_empty()', src/main.rs:286:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::test_validate_docset_params_1_into_args

test result: FAILED. 4 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

error: test failed, to rerun pass '--bin cargo-docset'
@Robzz
Copy link
Owner

Robzz commented Sep 21, 2022

I just reproduced this, thanks for the report, I'll look into that and get the CI back up to avoid any repeats.

@Robzz Robzz mentioned this issue Sep 21, 2022
@Robzz Robzz closed this as completed in #43 Sep 21, 2022
@antifuchs
Copy link
Contributor Author

Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants