Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isolate HOME #62

Closed
BrianHicks opened this issue Sep 23, 2022 · 0 comments · Fixed by #92
Closed

isolate HOME #62

BrianHicks opened this issue Sep 23, 2022 · 0 comments · Fixed by #92
Assignees
@BrianHicks
Labels
hacktoberfest isolation
Milestone
initial build

Comments

@BrianHicks
Copy link
Member

BrianHicks commented Sep 23, 2022 •
edited

we don't currently empty out the environment, which means that paths like HOME are totally available for caching, config files, etc. Not isolated even a little!

What we want: create a fake HOME, then look through it after the build completes. If the build leaves anything in it, issue a warning. Eventually this will be an error, but for now we don't have any way to work with mutable caches so we should be a little gentler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianHicks BrianHicks

Labels
hacktoberfest isolation
Projects
rbt
Status: Done
Milestone
initial build
Development

Successfully merging a pull request may close this issue.

warn about files being written to HOME roc-lang/rbt
1 participant
@BrianHicks