New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version compatibility checks #83

Open

gavv opened this issue Apr 5, 2023 · 0 comments

Labels

enhancement good first issue help wanted

Member

gavv commented Apr 5, 2023 •

edited

Loading

This should be done after #57

When the library is initialized, we need to retrieve versions of native lib and go bindings, and check the following invariant:

major versions are equal
minor version of bindings is greater than or equal to minor version of native lib

(See "Versioning" section in Readme for explanation)

If the invariant is not satisfied, we should throw an exception with a message including the retrieved versions and explanation of what is wrong.

We can do this check in RocLibrary.loadLibrary.

gavv added enhancement good first issue help wanted labels

gavv changed the title ~~Add version checking~~ Add version compatibility checks

gavv mentioned this issue

Log version information during initialization #98

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment