Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad setup.py in 0.2.5 #59

Closed
wontonst opened this issue Sep 7, 2017 · 3 comments
Closed

Bad setup.py in 0.2.5 #59

wontonst opened this issue Sep 7, 2017 · 3 comments

Comments

@wontonst
Copy link

wontonst commented Sep 7, 2017

0.2.4 is fine, regression occurs at 0.2.5

Repro is easy:

pip install -v flask-googlemaps

Tidbit you're interested in is

Installing collected packages: Werkzeug, MarkupSafe, Jinja2, click, itsdangerous, flask, flask-googlemaps

  Compiling /private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncfilters.py ...
    File "/private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncfilters.py", line 7
      async def auto_to_seq(value):
              ^
  SyntaxError: invalid syntax

  Compiling /private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncsupport.py ...
    File "/private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncsupport.py", line 22
      async def concat_async(async_gen):
              ^
  SyntaxError: invalid syntax

Impact to user is when you do pip freeze it won't show Flask-GoogleMaps==0.2.5

The error is coming from Jinja but pip install Flask still causes Flask to show up in pip freeze, so something is wrong with the setup.py

@mattdaviscodes
Copy link
Contributor

Thanks @wontonst! @rochacbruno, this is what I was talking about in my comment on PR #56.

For reference, here's the stack overflow question: https://stackoverflow.com/questions/46105730/why-doesnt-pip-installed-package-show-up-in-pip-freeze

@vit0r
Copy link

vit0r commented Feb 21, 2020

@wontonst the setup.py was replaced by pyproject.toml

Poetry Python packaging and dependency management

@Riverfount
Copy link
Member

Please use the new release of the project! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants